]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpuidle: governors: teo: Drop redundant function parameter
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 12 Nov 2025 16:23:24 +0000 (17:23 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 14 Nov 2025 14:20:01 +0000 (15:20 +0100)
The last no_poll parameter of teo_find_shallower_state() is always
false, so drop it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Tested-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/2253109.irdbgypaU6@rafael.j.wysocki
drivers/cpuidle/governors/teo.c

index cc74cecbea7f4c0bd28e836b0c8c943b0f7c717a..ada42e2ca759375ea12d78c7b2dea25b79dbdfbb 100644 (file)
@@ -239,17 +239,15 @@ static bool teo_state_ok(int i, struct cpuidle_driver *drv)
  * @dev: Target CPU.
  * @state_idx: Index of the capping idle state.
  * @duration_ns: Idle duration value to match.
- * @no_poll: Don't consider polling states.
  */
 static int teo_find_shallower_state(struct cpuidle_driver *drv,
                                    struct cpuidle_device *dev, int state_idx,
-                                   s64 duration_ns, bool no_poll)
+                                   s64 duration_ns)
 {
        int i;
 
        for (i = state_idx - 1; i >= 0; i--) {
-               if (dev->states_usage[i].disable ||
-                               (no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING))
+               if (dev->states_usage[i].disable)
                        continue;
 
                state_idx = i;
@@ -459,7 +457,7 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
         * candidate state, a shallower one needs to be found.
         */
        if (drv->states[idx].target_residency_ns > duration_ns)
-               idx = teo_find_shallower_state(drv, dev, idx, duration_ns, false);
+               idx = teo_find_shallower_state(drv, dev, idx, duration_ns);
 
        /*
         * If the selected state's target residency is below the tick length
@@ -487,7 +485,7 @@ end:
         */
        if (idx > idx0 &&
            drv->states[idx].target_residency_ns > delta_tick)
-               idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false);
+               idx = teo_find_shallower_state(drv, dev, idx, delta_tick);
 
 out_tick:
        *stop_tick = false;