]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: hpsa: Fix allocation size for Scsi_Host private data
authorYuri Karpov <YKarpov@ispras.ru>
Tue, 12 Mar 2024 17:04:47 +0000 (20:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:32:06 +0000 (13:32 +0200)
[ Upstream commit 504e2bed5d50610c1836046c0c195b0a6dba9c72 ]

struct Scsi_Host private data contains pointer to struct ctlr_info.

Restore allocation of only 8 bytes to store pointer in struct Scsi_Host
private data area.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: bbbd25499100 ("scsi: hpsa: Fix allocation size for scsi_host_alloc()")
Signed-off-by: Yuri Karpov <YKarpov@ispras.ru>
Link: https://lore.kernel.org/r/20240312170447.743709-1-YKarpov@ispras.ru
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/hpsa.c

index a44a098dbb9c7aa20379bcb43c9010a1b5d7e3d7..4e7ec83c07cf6488d376eaa1877eb580ab8d1791 100644 (file)
@@ -5834,7 +5834,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h)
 {
        struct Scsi_Host *sh;
 
-       sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info));
+       sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info *));
        if (sh == NULL) {
                dev_err(&h->pdev->dev, "scsi_host_alloc failed\n");
                return -ENOMEM;