s3:rpc_server: fix use after free in rpc_worker_new_client() error path

dcesrv_conn is a client of ncacn_conn, so we can't call
TALLOC_FREE(dcesrv_conn); after TALLOC_FREE(ncacn_conn);

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

diff --git a/source3/rpc_server/rpc_worker.c b/source3/rpc_server/rpc_worker.c
index b6d3420f61d15165cbcaa11ee1b96fca25e68754..635dae10ca508c2bb36653ed14297d8d2713848e 100644 (file)
--- a/source3/rpc_server/rpc_worker.c
+++ b/source3/rpc_server/rpc_worker.c
@@ -504,7 +504,6 @@ static void rpc_worker_new_client(
        return;
 fail:
        TALLOC_FREE(ncacn_conn);
-       TALLOC_FREE(dcesrv_conn);
        TALLOC_FREE(client);
        if (sock != -1) {
                close(sock);