Implement some suggestions from clang-tidy 10

diff --git a/src/Context.cpp b/src/Context.cpp
index 96044f112ec2ba0a4df69564e414eabc554b131b..9dc5458792d00a4841a486a79ec5c35c8bec8bc7 100644 (file)
--- a/src/Context.cpp
+++ b/src/Context.cpp
@@ -81,7 +81,7 @@ void
 Context::set_path_and_stats_file(const Digest& name,
                                  string_view suffix,
                                  std::string& path_var,
-                                 std::string& stats_file_var)
+                                 std::string& stats_file_var) const
 {
   std::string name_string = name.to_string();
   path_var = Util::get_path_in_cache(

diff --git a/src/Context.hpp b/src/Context.hpp
index 2579f75c067832fbb9ebe361dc37710fec81237e..385daedee03218c37872eeadf47fb6220c808efb 100644 (file)
--- a/src/Context.hpp
+++ b/src/Context.hpp
@@ -157,7 +157,7 @@ private:
   void set_path_and_stats_file(const Digest& name,
                                nonstd::string_view suffix,
                                std::string& path_var,
-                               std::string& stats_file_var);
+                               std::string& stats_file_var) const;
 };
 
 inline const Digest&

diff --git a/src/InodeCache.hpp b/src/InodeCache.hpp
index 69b5ceccef13e1e01afe82c8eccffd8aa46a858c..a538940ed97b06eeca28dae557c49e287efc169d 100644 (file)
--- a/src/InodeCache.hpp
+++ b/src/InodeCache.hpp
@@ -99,11 +99,11 @@ private:
   struct SharedRegion;
 
   bool mmap_file(const std::string& inode_cache_file);
-  bool hash_inode(const char* path, ContentType type, Digest& digest);
+  static bool hash_inode(const char* path, ContentType type, Digest& digest);
   Bucket* acquire_bucket(uint32_t index);
   Bucket* acquire_bucket(const Digest& key_digest);
-  void release_bucket(Bucket* bucket);
-  bool create_new_file(const std::string& filename);
+  static void release_bucket(Bucket* bucket);
+  static bool create_new_file(const std::string& filename);
   bool initialize();
 
   const Config& m_config;