Don't use uninitialized values

This fixes a bunch or valgrind errors.

diff --git a/client.c b/client.c
index a8c4ad26702ea9c642aa8476d55002315d6db961..bd250fe319c246e303fbe44e9fc265f664debf3e 100644 (file)
--- a/client.c
+++ b/client.c
@@ -1158,6 +1158,8 @@ submit_request(CMD_Request *request, CMD_Reply *reply, int *reply_auth_ok)
         request->utoken = htonl(SPECIAL_UTOKEN);
       }
       generate_auth(request);
+    } else {
+      memset(request->auth, 0, sizeof (request->auth));
     }
 
     command_length = PKL_CommandLength(request);

diff --git a/ntp_core.c b/ntp_core.c
index fcbe04650c4271ea050dc961e833b85b42c3deac..4f0eb4164833d04e74a595e80105e4bb859b3336 100644 (file)
--- a/ntp_core.c
+++ b/ntp_core.c
@@ -323,6 +323,8 @@ create_instance(NTP_Remote_Address *remote_addr, NTP_Mode mode, SourceParameters
 
   result->local_rx.tv_sec = 0;
   result->local_rx.tv_usec = 0;
+  result->local_tx.tv_sec = 0;
+  result->local_tx.tv_usec = 0;
 
   return result;
 

diff --git a/ntp_io.c b/ntp_io.c
index 4e4b98966565bf4eb0ce6bfd86e7fde7c586b4fc..d67310588ba8d2fc69a0ef41d10391abdec3a6fc 100644 (file)
--- a/ntp_io.c
+++ b/ntp_io.c
@@ -307,13 +307,14 @@ send_packet(void *packet, int packetlen, NTP_Remote_Address *remote_addr)
     struct in_pktinfo *ipi;
 
     cmsg = CMSG_FIRSTHDR(&msg);
+    memset(cmsg, 0, CMSG_SPACE(sizeof(struct in_pktinfo)));
+    cmsglen += CMSG_SPACE(sizeof(struct in_pktinfo));
+
     cmsg->cmsg_level = IPPROTO_IP;
     cmsg->cmsg_type = IP_PKTINFO;
     cmsg->cmsg_len = CMSG_LEN(sizeof(struct in_pktinfo));
-    cmsglen += CMSG_SPACE(sizeof(struct in_pktinfo));
 
     ipi = (struct in_pktinfo *) CMSG_DATA(cmsg);
-    memset(ipi, 0, sizeof(struct in_pktinfo));
     ipi->ipi_spec_dst.s_addr = htonl(remote_addr->local_ip_addr);
 #if 0
     LOG(LOGS_INFO, LOGF_NtpIO, "sending to %s:%d from %s",

diff --git a/sourcestats.c b/sourcestats.c
index 564eb3acfbf25b9262a7d061b2b5a8e9b203d89e..33c1a1bf0d775406b1d683152505b2e552e1135d 100644 (file)
--- a/sourcestats.c
+++ b/sourcestats.c
@@ -198,6 +198,8 @@ SST_CreateInstance(unsigned long refid)
   inst->skew_dirn = SST_Skew_Nochange;
   inst->estimated_offset = 0.0;
   inst->estimated_offset_sd = 86400.0; /* Assume it's at least within a day! */
+  inst->offset_time.tv_sec = 0;
+  inst->offset_time.tv_usec = 0;
   inst->variance = 16.0;
   inst->nruns = 0;
   return inst;
@@ -874,6 +876,7 @@ SST_DoSourceReport(SST_Stats inst, RPT_SourceReport *report, struct timeval *now
       report->resid_skew = 0;
     }
   } else {
+    report->latest_meas_ago = 86400 * 365 * 10;
     report->orig_latest_meas = 0;
     report->latest_meas = 0;
     report->latest_meas_err = 0;