]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: fix return code when spi device has too many chipselects
authorJonas Gorski <jonas.gorski@gmail.com>
Mon, 15 Sep 2025 18:37:19 +0000 (20:37 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 22 Sep 2025 08:29:40 +0000 (09:29 +0100)
Don't return a positive value when there are too many chipselects.

Fixes: 4d8ff6b0991d ("spi: Add multi-cs memories support in SPI core")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Link: https://patch.msgid.link/20250915183725.219473-2-jonas.gorski@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index f95c4304df8e91200dc84ad4c7a99f2308bfdab7..b07d6cdf587ceec0849acd4932b570bdfe3aed7d 100644 (file)
@@ -2445,7 +2445,7 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi,
        if (rc > ctlr->num_chipselect) {
                dev_err(&ctlr->dev, "%pOF has number of CS > ctlr->num_chipselect (%d)\n",
                        nc, rc);
-               return rc;
+               return -EINVAL;
        }
        if ((of_property_present(nc, "parallel-memories")) &&
            (!(ctlr->flags & SPI_CONTROLLER_MULTI_CS))) {