]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: dw-mmio: add error handling for reset_control_deassert()
authorArtem Shimko <a.shimko.dev@gmail.com>
Tue, 7 Oct 2025 10:11:33 +0000 (13:11 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 7 Oct 2025 12:19:49 +0000 (13:19 +0100)
Currently reset_control_deassert() is called without checking its
return value. This can lead to silent failures when reset deassertion
fails.

Add proper error handling to:
1. Check the return value of reset_control_deassert()
2. Return the error to the caller
3. Provide meaningful error message using dev_err_probe()

This ensures that reset-related failures are properly reported during
probe and helps with debugging reset issues.

Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
Link: https://patch.msgid.link/20251007101134.1912895-1-a.shimko.dev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-mmio.c

index f0f576fac77afed6ca2ddc0d31e37bc76462c736..7a5197586919cdd53feb6bf46cacd5320c18e04b 100644 (file)
@@ -358,7 +358,9 @@ static int dw_spi_mmio_probe(struct platform_device *pdev)
        if (IS_ERR(dwsmmio->rstc))
                return PTR_ERR(dwsmmio->rstc);
 
-       reset_control_deassert(dwsmmio->rstc);
+       ret = reset_control_deassert(dwsmmio->rstc);
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret, "Failed to deassert resets\n");
 
        dws->bus_num = pdev->id;