systemd: use "Type=simple" for mdcheck services

"Type=oneshot" means that systemd considers the unit as started when the
started process exits. But the "mdcheck" script may run for several
hours.  Thus systemd will regard the unit as "activating" all the
time. This can be easily tested by running "systemctl start
mdcheck_start.service" manually. The systemctl command will not finish
until the mdcheck utility has finished or Ctrl-C is typed, which is
broken.

Use "Type=simple" instead.

Signed-off-by: Martin Wilck <mwilck@suse.com>

diff --git a/systemd/mdcheck_continue.service b/systemd/mdcheck_continue.service
index 70892a1f60182bad226d1092ece1ee0e2e6e4722..cd12db850e423d6481f904da5ec5bb5917dbfb88 100644 (file)
--- a/systemd/mdcheck_continue.service
+++ b/systemd/mdcheck_continue.service
@@ -11,6 +11,6 @@ ConditionPathExistsGlob=/var/lib/mdcheck/MD_UUID_*
 Documentation=man:mdadm(8)
 
 [Service]
-Type=oneshot
+Type=simple
 Environment="MDADM_CHECK_DURATION=6 hours"
 ExecStart=/usr/share/mdadm/mdcheck --continue --duration ${MDADM_CHECK_DURATION}

diff --git a/systemd/mdcheck_start.service b/systemd/mdcheck_start.service
index fc4fc4388c6c7377395818837e99102b51f025f4..16ba6b67a1ce389e183b5f619975d5098cdc8b5b 100644 (file)
--- a/systemd/mdcheck_start.service
+++ b/systemd/mdcheck_start.service
@@ -11,6 +11,6 @@ Wants=mdcheck_continue.timer
 Documentation=man:mdadm(8)
 
 [Service]
-Type=oneshot
+Type=simple
 Environment="MDADM_CHECK_DURATION=6 hours"
 ExecStart=/usr/share/mdadm/mdcheck --duration ${MDADM_CHECK_DURATION}