]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: SDCA: Update memory allocations to zero initialise
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 15 Jul 2025 15:17:23 +0000 (16:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 14:38:34 +0000 (16:38 +0200)
[ Upstream commit 15247b5a63f506125360fa45d7aa1fbe8b903b95 ]

All the memory allocations in the SDCA ASoC helpers rely on fields being
zero initialised, the code should use kzalloc not kmalloc.

Reported-by: Shuming Fan <shumingf@realtek.com>
Fixes: 2c8b3a8e6aa8 ("ASoC: SDCA: Create DAPM widgets and routes from DisCo")
Fixes: c3ca24e3fcb6 ("ASoC: SDCA: Create ALSA controls from DisCo")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20250715151723.2964336-4-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/sdca/sdca_asoc.c

index e96e696cb1079afdf5bdc7faa00e41d331a39ece..febc57b2a0b5d1cce8f17d66ef513eff2ee20dda 100644 (file)
@@ -229,11 +229,11 @@ static int entity_early_parse_ge(struct device *dev,
        if (!control_name)
                return -ENOMEM;
 
-       kctl = devm_kmalloc(dev, sizeof(*kctl), GFP_KERNEL);
+       kctl = devm_kzalloc(dev, sizeof(*kctl), GFP_KERNEL);
        if (!kctl)
                return -ENOMEM;
 
-       soc_enum = devm_kmalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
+       soc_enum = devm_kzalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
        if (!soc_enum)
                return -ENOMEM;
 
@@ -560,11 +560,11 @@ static int entity_parse_su_class(struct device *dev,
        const char **texts;
        int i;
 
-       kctl = devm_kmalloc(dev, sizeof(*kctl), GFP_KERNEL);
+       kctl = devm_kzalloc(dev, sizeof(*kctl), GFP_KERNEL);
        if (!kctl)
                return -ENOMEM;
 
-       soc_enum = devm_kmalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
+       soc_enum = devm_kzalloc(dev, sizeof(*soc_enum), GFP_KERNEL);
        if (!soc_enum)
                return -ENOMEM;
 
@@ -671,7 +671,7 @@ static int entity_parse_mu(struct device *dev,
                if (!control_name)
                        return -ENOMEM;
 
-               mc = devm_kmalloc(dev, sizeof(*mc), GFP_KERNEL);
+               mc = devm_kzalloc(dev, sizeof(*mc), GFP_KERNEL);
                if (!mc)
                        return -ENOMEM;
 
@@ -925,7 +925,7 @@ static int populate_control(struct device *dev,
        if (!control_name)
                return -ENOMEM;
 
-       mc = devm_kmalloc(dev, sizeof(*mc), GFP_KERNEL);
+       mc = devm_kzalloc(dev, sizeof(*mc), GFP_KERNEL);
        if (!mc)
                return -ENOMEM;