]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: light: vcnl4000: Use a structure to make buffer arrangement explicit.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 2 Aug 2025 16:44:34 +0000 (17:44 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 16 Aug 2025 14:57:51 +0000 (15:57 +0100)
Removes the need for comments to describe the buffer passed to
iio_push_to_buffers_with_timestamp().

Reviewed-by: MÃ¥rten Lindahl <marten.lindahl@axis.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://patch.msgid.link/20250802164436.515988-15-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/vcnl4000.c

index 90e7d4421abf20d1b2104c7932e9383e5d43229c..eccf690eae8c4db9eaa5ef63ccea1fb314640067 100644 (file)
@@ -1662,7 +1662,10 @@ static irqreturn_t vcnl4010_trigger_handler(int irq, void *p)
        struct iio_dev *indio_dev = pf->indio_dev;
        struct vcnl4000_data *data = iio_priv(indio_dev);
        const unsigned long *active_scan_mask = indio_dev->active_scan_mask;
-       u16 buffer[8] __aligned(8) = {0}; /* 1x16-bit + naturally aligned ts */
+       struct {
+               u16 chan;
+               aligned_s64 ts;
+       } scan = { };
        bool data_read = false;
        unsigned long isr;
        int val = 0;
@@ -1682,7 +1685,7 @@ static irqreturn_t vcnl4010_trigger_handler(int irq, void *p)
                        if (ret < 0)
                                goto end;
 
-                       buffer[0] = val;
+                       scan.chan = val;
                        data_read = true;
                }
        }
@@ -1695,7 +1698,7 @@ static irqreturn_t vcnl4010_trigger_handler(int irq, void *p)
        if (!data_read)
                goto end;
 
-       iio_push_to_buffers_with_timestamp(indio_dev, buffer,
+       iio_push_to_buffers_with_timestamp(indio_dev, &scan,
                                           iio_get_time_ns(indio_dev));
 
 end: