]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cpufreq: CPPC: Don't warn if FIE init fails to read counters
authorJie Zhan <zhanjie9@hisilicon.com>
Thu, 28 Aug 2025 11:02:11 +0000 (19:02 +0800)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 28 Oct 2025 05:10:47 +0000 (10:40 +0530)
During the CPPC FIE initialization, reading perf counters on offline cpus
should be expected to fail.  Don't warn on this case.

Also, change the error log level to debug since FIE is optional.

Co-developed-by: Bowen Yu <yubowen8@huawei.com>
Signed-off-by: Bowen Yu <yubowen8@huawei.com> # Changing loglevel to debug
Signed-off-by: Jie Zhan <zhanjie9@hisilicon.com>
[ Viresh: Added back the dropped comment. ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cppc_cpufreq.c

index e23d9abea13592d8818157bd79286cfd6db2f896..9eac77c4f2944ecdb8b79d35cad181497d1e183e 100644 (file)
@@ -142,16 +142,15 @@ static void cppc_cpufreq_cpu_fie_init(struct cpufreq_policy *policy)
                init_irq_work(&cppc_fi->irq_work, cppc_irq_work);
 
                ret = cppc_get_perf_ctrs(cpu, &cppc_fi->prev_perf_fb_ctrs);
-               if (ret) {
-                       pr_warn("%s: failed to read perf counters for cpu:%d: %d\n",
-                               __func__, cpu, ret);
 
-                       /*
-                        * Don't abort if the CPU was offline while the driver
-                        * was getting registered.
-                        */
-                       if (cpu_online(cpu))
-                               return;
+               /*
+                * Don't abort as the CPU was offline while the driver was
+                * getting registered.
+                */
+               if (ret && cpu_online(cpu)) {
+                       pr_debug("%s: failed to read perf counters for cpu:%d: %d\n",
+                               __func__, cpu, ret);
+                       return;
                }
        }