]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: winbind: Add missing NULL check for returned talloc'ed ADS struct.
authorJeremy Allison <jra@samba.org>
Wed, 29 Jun 2022 15:20:21 +0000 (08:20 -0700)
committerJeremy Allison <jra@samba.org>
Thu, 30 Jun 2022 15:35:32 +0000 (15:35 +0000)
Coverity CID: 1506720.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/winbindd_cm.c

index 64441b4db163ebfb1d8a34c90b51b39e76895545..28316e10d72d4a0c77b1832c173158d0b2fd1b10 100644 (file)
@@ -1099,6 +1099,10 @@ static bool dcip_check_name_ads(const struct winbindd_domain *domain,
                       domain->name,
                       addr,
                       ADS_SASL_PLAIN);
+       if (ads == NULL) {
+               ads_status = ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
+               goto out;
+       }
        ads->auth.flags |= ADS_AUTH_NO_BIND;
        ads->config.flags |= request_flags;
        ads->server.no_fallback = true;