]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
smtp/mime: allow unquoted name/filename fields
authorVictor Julien <victor@inliniac.net>
Thu, 21 Apr 2016 13:14:45 +0000 (15:14 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 25 Apr 2016 13:32:14 +0000 (15:32 +0200)
Don't enforce that name/filename fields are quoted.

Reported-By: Blair Steven
src/util-decode-mime.c

index 81d8bc720bd14e8c96aa7532c90fbdca01001485..60206c20e32c0935fca444ae21b031477ece5360 100644 (file)
@@ -1891,7 +1891,7 @@ static int ProcessMimeHeaders(const uint8_t *buf, uint32_t len,
         /* Check for file attachment in content disposition */
         field = MimeDecFindField(entity, CTNT_DISP_STR);
         if (field != NULL) {
-            bptr = FindMimeHeaderToken(field, "filename=\"", TOK_END_STR, &blen);
+            bptr = FindMimeHeaderToken(field, "filename=", TOK_END_STR, &blen);
             if (bptr != NULL) {
                 SCLogDebug("File attachment found in disposition");
                 entity->ctnt_flags |= CTNT_IS_ATTACHMENT;
@@ -1933,7 +1933,7 @@ static int ProcessMimeHeaders(const uint8_t *buf, uint32_t len,
 
             /* Look for file name (if not already found) */
             if (!(entity->ctnt_flags & CTNT_IS_ATTACHMENT)) {
-                bptr = FindMimeHeaderToken(field, "name=\"", TOK_END_STR, &blen);
+                bptr = FindMimeHeaderToken(field, "name=", TOK_END_STR, &blen);
                 if (bptr != NULL) {
                     SCLogDebug("File attachment found");
                     entity->ctnt_flags |= CTNT_IS_ATTACHMENT;