]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i3c: master: dw-i3c: Balance PM runtime usage count on probe failure
authorFelix Gu <ustc.gu@gmail.com>
Sat, 21 Mar 2026 09:04:43 +0000 (17:04 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Apr 2026 14:38:50 +0000 (16:38 +0200)
When DW_I3C_DISABLE_RUNTIME_PM_QUIRK is set, the probe function calls
pm_runtime_get_noresume() to prevent runtime suspend. However, if
i3c_master_register() fails, the error path does not balance this
call, leaving the usage count incremented.

Add pm_runtime_put_noidle() in the error cleanup path to properly
balance the usage count.

Fixes: fba0e56ee752 ("i3c: dw: Disable runtime PM on Agilex5 to avoid bus hang on IBI")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260321-dw-i3c-1-v1-1-821623aac7bb@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/dw-i3c-master.c

index 3379cb16eeca56f6cc20dd7ed6d90c8b4838ed78..b87073d2f8afaf84febdca2a072f02f5a2653072 100644 (file)
@@ -1667,6 +1667,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
        return 0;
 
 err_disable_pm:
+       if (master->quirks & DW_I3C_DISABLE_RUNTIME_PM_QUIRK)
+               pm_runtime_put_noidle(&pdev->dev);
        pm_runtime_disable(&pdev->dev);
        pm_runtime_set_suspended(&pdev->dev);
        pm_runtime_dont_use_autosuspend(&pdev->dev);