]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
ui/pixman: Fix crash in qemu_pixman_shareable_free()
authorMarkus Armbruster <armbru@redhat.com>
Mon, 13 Oct 2025 11:21:02 +0000 (13:21 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 21 Oct 2025 07:54:48 +0000 (09:54 +0200)
Reported-by: Bernhard Beschow <shentey@gmail.com>
Fixes: b296b29d3414 (ui/pixman: Consistent error handling in qemu_pixman_shareable_free())
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20251013112102.2396012-1-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
ui/qemu-pixman.c

index e46c6232cfaa9d6b6fc684280e49988fa08855cc..aea09755b9495d9d97e618d8d9cd0f600c4f176f 100644 (file)
@@ -291,7 +291,9 @@ qemu_pixman_shareable_free(qemu_pixman_shareable handle,
     Error *err = NULL;
 
     qemu_win32_map_free(ptr, handle, &err);
-    error_report_err(err);
+    if (err) {
+        error_report_err(err);
+    }
 #else
     qemu_memfd_free(ptr, size, handle);
 #endif