s4:dns_server: Check return value of ldb_transaction_commit() (CID 1034631)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c
index 13f16f244f87bf281dd248e71394290da94ef57c..4d2ee0bac713343945dd4f86aa43ebb21c618e23 100644 (file)
--- a/source4/dns_server/dns_update.c
+++ b/source4/dns_server/dns_update.c
@@ -753,7 +753,10 @@ static WERROR handle_updates(struct dns_server *dns,
 
 failed:
        if (W_ERROR_IS_OK(werror)) {
-               ldb_transaction_commit(dns->samdb);
+               ret = ldb_transaction_commit(dns->samdb);
+               if (ret != LDB_SUCCESS) {
+                       werror = DNS_ERR(SERVER_FAILURE);
+               }
        } else {
                ldb_transaction_cancel(dns->samdb);
        }