Rename heapam_index_fetch_tuple argument for clarity.

Rename heapam_index_fetch_tuple's call_again argument to heap_continue,
for consistency with the pointed-to variable name (IndexScanDescData's
xs_heap_continue field).

Preparation for an upcoming commit that will move index scan related
heapam functions into their own file.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/bmbrkiyjxoal6o5xadzv5bveoynrt3x37wqch7w3jnwumkq2yo@b4zmtnrfs4mh

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 1be8ea4845a991bf6166e31b133c167356bfbae4..dc7db58857c580867809789fe7d01a8fbf4e0e09 100644 (file)
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -126,7 +126,7 @@ heapam_index_fetch_tuple(struct IndexFetchTableData *scan,
                                                 ItemPointer tid,
                                                 Snapshot snapshot,
                                                 TupleTableSlot *slot,
-                                                bool *call_again, bool *all_dead)
+                                                bool *heap_continue, bool *all_dead)
 {
        IndexFetchHeapData *hscan = (IndexFetchHeapData *) scan;
        BufferHeapTupleTableSlot *bslot = (BufferHeapTupleTableSlot *) slot;
@@ -135,7 +135,7 @@ heapam_index_fetch_tuple(struct IndexFetchTableData *scan,
        Assert(TTS_IS_BUFFERTUPLE(slot));
 
        /* We can skip the buffer-switching logic if we're in mid-HOT chain. */
-       if (!*call_again)
+       if (!*heap_continue)
        {
                /* Switch to correct buffer if we don't have it already */
                Buffer          prev_buf = hscan->xs_cbuf;
@@ -161,7 +161,7 @@ heapam_index_fetch_tuple(struct IndexFetchTableData *scan,
                                                                                        snapshot,
                                                                                        &bslot->base.tupdata,
                                                                                        all_dead,
-                                                                                       !*call_again);
+                                                                                       !*heap_continue);
        bslot->base.tupdata.t_self = *tid;
        LockBuffer(hscan->xs_cbuf, BUFFER_LOCK_UNLOCK);
 
@@ -171,7 +171,7 @@ heapam_index_fetch_tuple(struct IndexFetchTableData *scan,
                 * Only in a non-MVCC snapshot can more than one member of the HOT
                 * chain be visible.
                 */
-               *call_again = !IsMVCCLikeSnapshot(snapshot);
+               *heap_continue = !IsMVCCLikeSnapshot(snapshot);
 
                slot->tts_tableOid = RelationGetRelid(scan->rel);
                ExecStoreBufferHeapTuple(&bslot->base.tupdata, slot, hscan->xs_cbuf);
@@ -179,7 +179,7 @@ heapam_index_fetch_tuple(struct IndexFetchTableData *scan,
        else
        {
                /* We've reached the end of the HOT chain. */
-               *call_again = false;
+               *heap_continue = false;
        }
 
        return got_heap_tuple;