]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[master] Fixed missing log placeholder in b10-dhcp4
authorThomas Markwalder <tmark@isc.org>
Fri, 4 Apr 2014 13:31:04 +0000 (09:31 -0400)
committerThomas Markwalder <tmark@isc.org>
Fri, 4 Apr 2014 13:31:04 +0000 (09:31 -0400)
Testing undercovered a missing log place holder in Dhcp4_srv.cc, which
surfaces when a release for a non-existance lease is received.
This has been corrected.

src/bin/dhcp4/dhcp4_messages.mes
src/bin/dhcp4/dhcp4_srv.cc

index 7fa3ee4394fd8c48ebb14e7ef18955ce2485b595..40215a2583afe8c3853bf3556a5f9d14d9b9c4cd 100644 (file)
@@ -295,7 +295,7 @@ intervention (e.g. check if DHCP process has sufficient privileges to
 update the database). It may also be triggered if a lease was manually
 removed from the database during RELEASE message processing.
 
-% DHCP4_RELEASE_FAIL_NO_LEASE client (client-id %2) tried to release address %1, but there is no lease for such address.
+% DHCP4_RELEASE_FAIL_NO_LEASE client (client-id %1, hwaddr %2) tried to release address, %3, but there is no such lease.
 This warning message is printed when client attempts to release a lease,
 but no such lease is known to the server.
 
index 0ad231958438b10f4583b9bd94e0a4aeee8e10b4..60b5a35c061c10a97b5fdf4edce7aab709b2799d 100644 (file)
@@ -1276,10 +1276,12 @@ Dhcpv4Srv::processRelease(Pkt4Ptr& release) {
 
         if (!lease) {
             // No such lease - bogus release
-            LOG_DEBUG(dhcp4_logger, DBG_DHCP4_DETAIL, DHCP4_RELEASE_FAIL_NO_LEASE)
-                .arg(release->getCiaddr().toText())
-                .arg(release->getHWAddr()->toText())
-                .arg(client_id ? client_id->toText() : "(no client-id)");
+            LOG_DEBUG(dhcp4_logger, DBG_DHCP4_DETAIL,
+                      DHCP4_RELEASE_FAIL_NO_LEASE)
+                      .arg(client_id ? client_id->toText() : "(no client-id)")
+                      .arg(release->getHWAddr() ?
+                           release->getHWAddr()->toText() : "(no hwaddr info)")
+                      .arg(release->getCiaddr().toText());
             return;
         }