libcli: Slightly streamline sddl_flags_to_string()

Only check for talloc failure once with talloc_asprintf_addbuf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 215321adb61fa7fd4bb090afeb5df5115771b135..fe24d4892b252b19ef5b515f2066ae723053e84f 100644 (file)
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -1051,12 +1051,15 @@ static char *sddl_flags_to_string(TALLOC_CTX *mem_ctx, const struct flag_map *ma
        /* now by bits */
        for (i=0;map[i].name;i++) {
                if ((flags & map[i].flag) != 0) {
-                       s = talloc_asprintf_append_buffer(s, "%s", map[i].name);
-                       if (s == NULL) goto failed;
+                       talloc_asprintf_addbuf(&s, "%s", map[i].name);
                        flags &= ~map[i].flag;
                }
        }
 
+       if (s == NULL) {
+               goto failed;
+       }
+
        if (check_all && flags != 0) {
                goto failed;
        }