rpcclient/rpcclient.c: Non-void return in void function.

smbd/sec_ctx.c: Fixed potential memory leak spotted by
Kenichi Okuyama@Tokyo Research Lab, IBM-Japan, Co.
utils/nmblookup.c: gcc warning on Solaris fix.
Jeremy.

diff --git a/source/smbd/sec_ctx.c b/source/smbd/sec_ctx.c
index f6563ffe96ea277601100c8f44dc023a4edd3972..6f98e9df6b062bd703154e2bfd608dd500548e51 100644 (file)
--- a/source/smbd/sec_ctx.c
+++ b/source/smbd/sec_ctx.c
@@ -152,8 +152,10 @@ int get_current_groups(int *p_ngroups, gid_t **p_groups)
                return -1;
        }
 
-       if ((ngroups = sys_getgroups(ngroups,groups)) == -1)
+       if ((ngroups = sys_getgroups(ngroups,groups)) == -1) {
+               safe_free(groups);
                return -1;
+       }
 
        (*p_ngroups) = ngroups;
        (*p_groups) = groups;

diff --git a/source/utils/nmblookup.c b/source/utils/nmblookup.c
index 4e85f6ac4568b9b85402492bfe27f32939ad5805..0f978a6cf3f77792a5a9abaa93fb7d3575b0b087 100644 (file)
--- a/source/utils/nmblookup.c
+++ b/source/utils/nmblookup.c
@@ -118,7 +118,7 @@ static void do_node_status(int fd, char *name, int type, struct in_addr ip)
                for (i=0;i<count;i++) {
                        fstrcpy(cleanname, status[i].name);
                        for (j=0;cleanname[j];j++) {
-                               if (!isprint(cleanname[j])) cleanname[j] = '.';
+                               if (!isprint((int)cleanname[j])) cleanname[j] = '.';
                        }
                        printf("\t%-15s <%02x> - %s\n",
                               cleanname,status[i].type,