dnsdist: Fix out-of-bounds read in SetMacAddrAction

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/dnsdistdist/dnsdist-actions-factory.cc b/pdns/dnsdistdist/dnsdist-actions-factory.cc
index ded8a537dc839890826bb94113ed8998a668a494..81795dff0fa390248b9de8bbc513e352a17af14f 100644 (file)
--- a/pdns/dnsdistdist/dnsdist-actions-factory.cc
+++ b/pdns/dnsdistdist/dnsdist-actions-factory.cc
@@ -986,9 +986,10 @@ public:
       return Action::None;
     }
 
-    std::string optRData;
     // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
-    generateEDNSOption(d_code, reinterpret_cast<const char*>(mac.data()), optRData);
+    std::string macStr(reinterpret_cast<const char*>(mac.data()), mac.size());
+    std::string optRData;
+    generateEDNSOption(d_code, macStr, optRData);
 
     if (dnsquestion->getHeader()->arcount > 0) {
       bool ednsAdded = false;