]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
rng_test_helpers: add a needless lock/unlock pair to please coverity
authorNick Mathewson <nickm@torproject.org>
Thu, 16 May 2019 19:03:54 +0000 (15:03 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 16 May 2019 19:04:40 +0000 (15:04 -0400)
Fix for CID 1444908

src/test/rng_test_helpers.c

index 262d380bdaa52c58d60f28133485a69aaa02ba81..04b7138471dd398f3a5cc763bf8c54b8a94b5140 100644 (file)
@@ -183,11 +183,14 @@ void
 testing_enable_prefilled_rng(const void *buffer, size_t buflen)
 {
   tor_assert(buflen > 0);
+  tor_assert(!rng_mutex);
   rng_mutex = tor_mutex_new();
 
+  tor_mutex_acquire(rng_mutex);
   prefilled_rng_buffer = tor_memdup(buffer, buflen);
   prefilled_rng_buflen = buflen;
   prefilled_rng_idx = 0;
+  tor_mutex_release(rng_mutex);
 
   MOCK(crypto_rand, crypto_rand_prefilled);
   MOCK(crypto_strongest_rand_, mock_crypto_strongest_rand);