]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-95950: Add a test for both `csv.Dialect` and `kwargs` (#95951)
authorNikita Sobolev <mail@sobolevn.me>
Mon, 29 Aug 2022 00:43:32 +0000 (03:43 +0300)
committerGitHub <noreply@github.com>
Mon, 29 Aug 2022 00:43:32 +0000 (17:43 -0700)
Lib/test/test_csv.py

index 51ca1f2ab29285428a1cab84e17d84e2750944b6..a2b00430c7dd6021ed573f102da80d92bec42901 100644 (file)
@@ -448,6 +448,34 @@ class TestDialectRegistry(unittest.TestCase):
         self.assertEqual(csv.get_dialect(name).delimiter, ';')
         self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name)))
 
+    def test_register_kwargs_override(self):
+        class mydialect(csv.Dialect):
+            delimiter = "\t"
+            quotechar = '"'
+            doublequote = True
+            skipinitialspace = False
+            lineterminator = '\r\n'
+            quoting = csv.QUOTE_MINIMAL
+
+        name = 'test_dialect'
+        csv.register_dialect(name, mydialect,
+                             delimiter=';',
+                             quotechar="'",
+                             doublequote=False,
+                             skipinitialspace=True,
+                             lineterminator='\n',
+                             quoting=csv.QUOTE_ALL)
+        self.addCleanup(csv.unregister_dialect, name)
+
+        # Ensure that kwargs do override attributes of a dialect class:
+        dialect = csv.get_dialect(name)
+        self.assertEqual(dialect.delimiter, ';')
+        self.assertEqual(dialect.quotechar, "'")
+        self.assertEqual(dialect.doublequote, False)
+        self.assertEqual(dialect.skipinitialspace, True)
+        self.assertEqual(dialect.lineterminator, '\n')
+        self.assertEqual(dialect.quoting, csv.QUOTE_ALL)
+
     def test_incomplete_dialect(self):
         class myexceltsv(csv.Dialect):
             delimiter = "\t"