]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolve: adjust error messages
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 4 Sep 2020 07:26:17 +0000 (16:26 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 4 Sep 2020 14:54:35 +0000 (23:54 +0900)
src/resolve/resolved-dns-stub.c

index 88a6a0616af2b2d5bd8268ddb1889230b0b5a7ad..a8011d16f30a02c8ae0775fcd807fb4567ffebc4 100644 (file)
@@ -534,19 +534,11 @@ static int manager_dns_stub_udp_fd_extra(Manager *m, DNSStubListenerExtra *l) {
         return 0;
 
 fail:
+        assert(r < 0);
         (void) in_addr_port_to_string(l->family, &l->address, l->port, &pretty);
         if (r == -EADDRINUSE)
-                return log_warning_errno(r,
-                                         "Another process is already listening on UDP socket %s.\n"
-                                         "Turning off local DNS stub extra support.", strnull(pretty));
-        if (r == -EPERM)
-                return log_warning_errno(r,
-                                         "Failed to listen on UDP socket %s: %m.\n"
-                                         "Turning off local DNS stub extra support.", strnull(pretty));
-
-        assert(r < 0);
-
-        return log_warning_errno(r, "Failed to listen on UDP socket %s, ignoring: %m", strnull(pretty));
+                return log_warning_errno(r, "Another process is already listening on UDP socket %s: %m", strnull(pretty));
+        return log_warning_errno(r, "Failed to listen on UDP socket %s: %m", strnull(pretty));
 }
 
 static int on_dns_stub_stream_packet(DnsStream *s) {
@@ -706,19 +698,11 @@ static int manager_dns_stub_tcp_fd_extra(Manager *m, DNSStubListenerExtra *l) {
         return 0;
 
 fail:
+        assert(r < 0);
         (void) in_addr_port_to_string(l->family, &l->address, l->port, &pretty);
         if (r == -EADDRINUSE)
-                return log_warning_errno(r,
-                                         "Another process is already listening on TCP socket %s.\n"
-                                         "Turning off local DNS stub extra support.", strnull(pretty));
-        if (r == -EPERM)
-                return log_warning_errno(r,
-                                         "Failed to listen on TCP socket %s: %m.\n"
-                                         "Turning off local DNS stub extra support.", strnull(pretty));
-
-        assert(r < 0);
-
-        return log_warning_errno(r, "Failed to listen on TCP socket %s, ignoring: %m", strnull(pretty));
+                return log_warning_errno(r, "Another process is already listening on TCP socket %s: %m", strnull(pretty));
+        return log_warning_errno(r, "Failed to listen on TCP socket %s: %m", strnull(pretty));
 }
 
 int manager_dns_stub_start(Manager *m) {