selftests/landlock: Add tests for invalid use of quiet flag

Make sure that these calls return EINVAL.

Test coverage for security/landlock is 91.6% of 2347 lines according to
LLVM 22.

Assisted-by: GitHub-Copilot:claude-opus-4.8
Signed-off-by: Tingmao Wang <m@maowtm.org>
Link: https://patch.msgid.link/9401d5c6468675863d944d6c26640d97db1a1f31.1781228815.git.m@maowtm.org
[mic: Add test coverage]
Signed-off-by: Mickaël Salaün <mic@digikod.net>

diff --git a/tools/testing/selftests/landlock/base_test.c b/tools/testing/selftests/landlock/base_test.c
index 84e91fcaa1b27247349d82b32b5b1ac5f80b5fad..cbd3c1669951a4ad675e311392cf99327e016bc7 100644 (file)
--- a/tools/testing/selftests/landlock/base_test.c
+++ b/tools/testing/selftests/landlock/base_test.c
@@ -526,4 +526,120 @@ TEST(cred_transfer)
        EXPECT_EQ(EACCES, errno);
 }
 
+TEST(useless_quiet_rule_fs)
+{
+       struct landlock_ruleset_attr ruleset_attr = {
+               .handled_access_fs = LANDLOCK_ACCESS_FS_READ_DIR,
+               .quiet_access_fs = 0,
+       };
+       struct landlock_path_beneath_attr path_beneath_attr = {
+               .allowed_access = LANDLOCK_ACCESS_FS_READ_DIR,
+       };
+       int ruleset_fd, root_fd;
+
+       drop_caps(_metadata);
+       ruleset_fd =
+               landlock_create_ruleset(&ruleset_attr, sizeof(ruleset_attr), 0);
+       ASSERT_LE(0, ruleset_fd);
+
+       root_fd = open("/", O_PATH | O_CLOEXEC);
+       ASSERT_LE(0, root_fd);
+       path_beneath_attr.parent_fd = root_fd;
+       ASSERT_EQ(-1, landlock_add_rule(ruleset_fd, LANDLOCK_RULE_PATH_BENEATH,
+                                       &path_beneath_attr,
+                                       LANDLOCK_ADD_RULE_QUIET));
+       ASSERT_EQ(EINVAL, errno);
+
+       /* Check that the rule had not been added. */
+       ASSERT_EQ(0, close(root_fd));
+       enforce_ruleset(_metadata, ruleset_fd);
+       ASSERT_EQ(0, close(ruleset_fd));
+
+       ASSERT_EQ(-1, open("/", O_RDONLY | O_DIRECTORY | O_CLOEXEC));
+       ASSERT_EQ(EACCES, errno);
+}
+
+TEST(useless_quiet_rule_net)
+{
+       struct landlock_ruleset_attr ruleset_attr = {
+               .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP,
+               .quiet_access_net = 0,
+       };
+       struct landlock_net_port_attr net_port_attr = {
+               .allowed_access = LANDLOCK_ACCESS_NET_BIND_TCP,
+               .port = 1024,
+       };
+       int ruleset_fd;
+
+       drop_caps(_metadata);
+       ruleset_fd =
+               landlock_create_ruleset(&ruleset_attr, sizeof(ruleset_attr), 0);
+       ASSERT_LE(0, ruleset_fd);
+
+       ASSERT_EQ(-1,
+                 landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_PORT,
+                                   &net_port_attr, LANDLOCK_ADD_RULE_QUIET));
+       ASSERT_EQ(EINVAL, errno);
+
+       ASSERT_EQ(0, close(ruleset_fd));
+}
+
+TEST(invalid_quiet_bits_1)
+{
+       const struct landlock_ruleset_attr ruleset_attr_fs = {
+               .handled_access_fs = LANDLOCK_ACCESS_FS_READ_DIR,
+               .quiet_access_fs = LANDLOCK_ACCESS_FS_WRITE_FILE,
+       };
+       const struct landlock_ruleset_attr ruleset_attr_net = {
+               .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP,
+               .quiet_access_net = LANDLOCK_ACCESS_NET_CONNECT_TCP,
+       };
+       const struct landlock_ruleset_attr ruleset_attr_scoped = {
+               .scoped = LANDLOCK_SCOPE_ABSTRACT_UNIX_SOCKET,
+               .quiet_scoped = LANDLOCK_SCOPE_SIGNAL,
+       };
+
+       /* Quiet bit set but not part of the handled mask. */
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_fs,
+                                             sizeof(ruleset_attr_fs), 0));
+       ASSERT_EQ(EINVAL, errno);
+
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_net,
+                                             sizeof(ruleset_attr_net), 0));
+       ASSERT_EQ(EINVAL, errno);
+
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_scoped,
+                                             sizeof(ruleset_attr_scoped), 0));
+       ASSERT_EQ(EINVAL, errno);
+}
+
+TEST(invalid_quiet_bits_2)
+{
+       const struct landlock_ruleset_attr ruleset_attr_fs = {
+               .handled_access_fs = LANDLOCK_ACCESS_FS_READ_DIR,
+               .quiet_access_fs = 1ULL << 63,
+       };
+       const struct landlock_ruleset_attr ruleset_attr_net = {
+               .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP,
+               .quiet_access_net = 1ULL << 63,
+       };
+       const struct landlock_ruleset_attr ruleset_attr_scoped = {
+               .scoped = LANDLOCK_SCOPE_ABSTRACT_UNIX_SOCKET,
+               .quiet_scoped = 1ULL << 63,
+       };
+
+       /* Quiet bit outside of the valid access range. */
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_fs,
+                                             sizeof(ruleset_attr_fs), 0));
+       ASSERT_EQ(EINVAL, errno);
+
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_net,
+                                             sizeof(ruleset_attr_net), 0));
+       ASSERT_EQ(EINVAL, errno);
+
+       ASSERT_EQ(-1, landlock_create_ruleset(&ruleset_attr_scoped,
+                                             sizeof(ruleset_attr_scoped), 0));
+       ASSERT_EQ(EINVAL, errno);
+}
+
 TEST_HARNESS_MAIN