]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: Fix missing break in ATOM_ARG_IMM Case of atom_get_src_int()
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Sat, 24 Feb 2024 02:18:52 +0000 (07:48 +0530)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:21:59 +0000 (18:21 -0400)
[ Upstream commit 7cf1ad2fe10634238b38442a851d89514cb14ea2 ]

Missing break statement in the ATOM_ARG_IMM case of a switch statement,
adds the missing break statement, ensuring that the program's control
flow is as intended.

Fixes the below:
drivers/gpu/drm/amd/amdgpu/atom.c:323 atom_get_src_int() warn: ignoring unreachable code.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Cc: Jammy Zhou <Jammy.Zhou@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/atom.c

index 4cfc786699c7fcaac2b903c463ea85bbd9379812..c1841fa873f564a087abb312d176b43e9dab5b55 100644 (file)
@@ -310,7 +310,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,
                                DEBUG("IMM 0x%02X\n", val);
                        return val;
                }
-               return 0;
+               break;
        case ATOM_ARG_PLL:
                idx = U8(*ptr);
                (*ptr)++;