]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ntfs: Add missing error code
authorEthan Tidmore <ethantidmore06@gmail.com>
Thu, 26 Feb 2026 16:09:05 +0000 (10:09 -0600)
committerNamjae Jeon <linkinjeon@kernel.org>
Fri, 27 Feb 2026 09:43:40 +0000 (18:43 +0900)
If ntfs_attr_iget() fails no error code is assigned to be returned.

Detected by Smatch:
fs/ntfs/attrib.c:2665 ntfs_attr_add() warn:
missing error code 'err'

Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
fs/ntfs/attrib.c

index e260540eb7c59455441bd36bde35274f145ae6ce..71ad870eceacd3163aa8365ceedd859b66d8f08c 100644 (file)
@@ -2661,6 +2661,7 @@ add_non_resident:
        /* Open new attribute and resize it. */
        attr_vi = ntfs_attr_iget(VFS_I(ni), type, name, name_len);
        if (IS_ERR(attr_vi)) {
+               err = PTR_ERR(attr_vi);
                ntfs_error(sb, "Failed to open just added attribute");
                goto rm_attr_err_out;
        }