]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-102033: Fix syntax error in `Tools/c-analyzer` (GH-102066)
authorNikita Sobolev <mail@sobolevn.me>
Wed, 22 Mar 2023 14:59:32 +0000 (17:59 +0300)
committerGitHub <noreply@github.com>
Wed, 22 Mar 2023 14:59:32 +0000 (07:59 -0700)
The easiest way to format strings with `{}` meaningful chars is via `%`.

14 files changed:
Tools/c-analyzer/c_analyzer/__main__.py
Tools/c-analyzer/c_analyzer/info.py
Tools/c-analyzer/c_common/info.py [deleted file]
Tools/c-analyzer/c_common/iterutil.py
Tools/c-analyzer/c_common/show.py [deleted file]
Tools/c-analyzer/c_parser/__main__.py
Tools/c-analyzer/c_parser/_state_machine.py [deleted file]
Tools/c-analyzer/c_parser/info.py
Tools/c-analyzer/c_parser/parser/_alt.py [deleted file]
Tools/c-analyzer/c_parser/parser/_delim.py [deleted file]
Tools/c-analyzer/c_parser/parser/_global.py
Tools/c-analyzer/cpython/__main__.py
Tools/c-analyzer/cpython/_analyzer.py
Tools/c-analyzer/cpython/_capi.py

index 5d89b29adf899e46ac491d13126d5f560f7473bd..cde39bc4e649d9a08ed8268ee22491d0fb548b64 100644 (file)
@@ -18,10 +18,8 @@ from c_common.scriptutil import (
     configure_logger,
     get_prog,
     filter_filenames,
-    iter_marks,
 )
 from c_parser.info import KIND
-from c_parser.match import is_type_decl
 from .match import filter_forward
 from . import (
     analyze as _analyze,
index 27c3a5a4ee76f2990760c243d1cc3956dac64fac..d231e07a60dd8eb39c9e84c6fbc6a2dd8d7efe33 100644 (file)
@@ -1,4 +1,3 @@
-from collections import namedtuple
 import os.path
 
 from c_common import fsutil
@@ -13,9 +12,6 @@ from c_parser.info import (
 from c_parser.match import (
     is_type_decl,
 )
-from .match import (
-    is_process_global,
-)
 
 
 IGNORED = _misc.Labeled('IGNORED')
diff --git a/Tools/c-analyzer/c_common/info.py b/Tools/c-analyzer/c_common/info.py
deleted file mode 100644 (file)
index e69de29..0000000
index 6ded105304e454684203f9b8e005aec155fdbbea..dda3dd57c1cf5cff74adc6967d74b088e7a00e8e 100644 (file)
@@ -1,7 +1,3 @@
-
-_NOT_SET = object()
-
-
 def peek_and_iter(items):
     if not items:
         return None, None
diff --git a/Tools/c-analyzer/c_common/show.py b/Tools/c-analyzer/c_common/show.py
deleted file mode 100644 (file)
index e69de29..0000000
index 78f47a1808f50b2bfff3b02b86cd2a7a0520033f..2454fcba8142917009c856e985a9f52f2377c3cb 100644 (file)
@@ -1,10 +1,7 @@
 import logging
-import os.path
 import sys
 
-from c_common import fsutil
 from c_common.scriptutil import (
-    CLIArgSpec as Arg,
     add_verbosity_cli,
     add_traceback_cli,
     add_kind_filtering_cli,
@@ -15,7 +12,6 @@ from c_common.scriptutil import (
     get_prog,
     main_for_filenames,
 )
-from .preprocessor import get_preprocessor
 from .preprocessor.__main__ import (
     add_common_cli as add_preprocessor_cli,
 )
diff --git a/Tools/c-analyzer/c_parser/_state_machine.py b/Tools/c-analyzer/c_parser/_state_machine.py
deleted file mode 100644 (file)
index 8753231..0000000
+++ /dev/null
@@ -1,244 +0,0 @@
-
-f'''
-    struct {ANON_IDENTIFIER};
-    struct {{ ... }}
-    struct {IDENTIFIER} {{ ... }}
-
-    union {ANON_IDENTIFIER};
-    union {{ ... }}
-    union {IDENTIFIER} {{ ... }}
-
-    enum {ANON_IDENTIFIER};
-    enum {{ ... }}
-    enum {IDENTIFIER} {{ ... }}
-
-    typedef {VARTYPE} {IDENTIFIER};
-    typedef {IDENTIFIER};
-    typedef {IDENTIFIER};
-    typedef {IDENTIFIER};
-'''
-
-
-def parse(srclines):
-    if isinstance(srclines, str):  # a filename
-        raise NotImplementedError
-
-
-
-# This only handles at most 10 nested levels.
-#MATCHED_PARENS = textwrap.dedent(rf'''
-#    # matched parens
-#    (?:
-#        [(]  # level 0
-#        (?:
-#            [^()]*
-#            [(]  # level 1
-#            (?:
-#                [^()]*
-#                [(]  # level 2
-#                (?:
-#                    [^()]*
-#                    [(]  # level 3
-#                    (?:
-#                        [^()]*
-#                        [(]  # level 4
-#                        (?:
-#                            [^()]*
-#                            [(]  # level 5
-#                            (?:
-#                                [^()]*
-#                                [(]  # level 6
-#                                (?:
-#                                    [^()]*
-#                                    [(]  # level 7
-#                                    (?:
-#                                        [^()]*
-#                                        [(]  # level 8
-#                                        (?:
-#                                            [^()]*
-#                                            [(]  # level 9
-#                                            (?:
-#                                                [^()]*
-#                                                [(]  # level 10
-#                                                [^()]*
-#                                                [)]
-#                                             )*
-#                                            [^()]*
-#                                            [)]
-#                                         )*
-#                                        [^()]*
-#                                        [)]
-#                                     )*
-#                                    [^()]*
-#                                    [)]
-#                                 )*
-#                                [^()]*
-#                                [)]
-#                             )*
-#                            [^()]*
-#                            [)]
-#                         )*
-#                        [^()]*
-#                        [)]
-#                     )*
-#                    [^()]*
-#                    [)]
-#                 )*
-#                [^()]*
-#                [)]
-#             )*
-#            [^()]*
-#            [)]
-#         )*
-#        [^()]*
-#        [)]
-#     )
-#    # end matched parens
-#    ''')
-
-r'''
-        # for loop
-        (?:
-            \s* \b for
-            \s* [(]
-            (
-                [^;]* ;
-                [^;]* ;
-                .*?
-             )  # <header>
-            [)]
-            \s*
-            (?:
-                (?:
-                    (
-                        {_ind(SIMPLE_STMT, 6)}
-                     )  # <stmt>
-                    ;
-                 )
-                |
-                ( {{ )  # <open>
-             )
-         )
-        |
-
-
-
-            (
-                (?:
-                    (?:
-                        (?:
-                            {_ind(SIMPLE_STMT, 6)}
-                         )?
-                        return \b \s*
-                        {_ind(INITIALIZER, 5)}
-                     )
-                    |
-                    (?:
-                        (?:
-                            {IDENTIFIER} \s*
-                            (?: . | -> ) \s*
-                         )*
-                        {IDENTIFIER}
-                        \s* = \s*
-                        {_ind(INITIALIZER, 5)}
-                     )
-                    |
-                    (?:
-                        {_ind(SIMPLE_STMT, 5)}
-                     )
-                 )
-                |
-                # cast compound literal
-                (?:
-                    (?:
-                        [^'"{{}};]*
-                        {_ind(STRING_LITERAL, 5)}
-                     )*
-                    [^'"{{}};]*?
-                    [^'"{{}};=]
-                    =
-                    \s* [(] [^)]* [)]
-                    \s* {{ [^;]* }}
-                 )
-             )  # <stmt>
-
-
-
-        # compound statement
-        (?:
-            (
-                (?:
-
-                    # "for" statements are handled separately above.
-                    (?: (?: else \s+ )? if | switch | while ) \s*
-                    {_ind(COMPOUND_HEAD, 5)}
-                 )
-                |
-                (?: else | do )
-                # We do not worry about compound statements for labels,
-                # "case", or "default".
-             )?  # <header>
-            \s*
-            ( {{ )  # <open>
-         )
-
-
-
-            (
-                (?:
-                    [^'"{{}};]*
-                    {_ind(STRING_LITERAL, 5)}
-                 )*
-                [^'"{{}};]*
-                # Presumably we will not see "== {{".
-                [^\s='"{{}};]
-             )?  # <header>
-
-
-
-            (
-                \b
-                (?:
-                    # We don't worry about labels with a compound statement.
-                    (?:
-                        switch \s* [(] [^{{]* [)]
-                     )
-                    |
-                    (?:
-                        case \b \s* [^:]+ [:]
-                     )
-                    |
-                    (?:
-                        default \s* [:]
-                     )
-                    |
-                    (?:
-                        do
-                     )
-                    |
-                    (?:
-                        while \s* [(] [^{{]* [)]
-                     )
-                    |
-                    #(?:
-                    #    for \s* [(] [^{{]* [)]
-                    # )
-                    #|
-                    (?:
-                        if \s* [(]
-                        (?: [^{{]* [^)] \s* {{ )* [^{{]*
-                        [)]
-                     )
-                    |
-                    (?:
-                        else
-                        (?:
-                            \s*
-                            if \s* [(]
-                            (?: [^{{]* [^)] \s* {{ )* [^{{]*
-                            [)]
-                         )?
-                     )
-                 )
-             )?  # <header>
-'''
index 3fa9fefbd5ec0b9d8951d273db8d4d65d8e01635..799f923787744784236639feb40382fb576c2dc3 100644 (file)
@@ -1,6 +1,5 @@
 from collections import namedtuple
 import enum
-import os.path
 import re
 
 from c_common import fsutil
@@ -8,7 +7,7 @@ from c_common.clsutil import classonly
 import c_common.misc as _misc
 import c_common.strutil as _strutil
 import c_common.tables as _tables
-from .parser._regexes import SIMPLE_TYPE, _STORAGE
+from .parser._regexes import _STORAGE
 
 
 FIXED_TYPE = _misc.Labeled('FIXED_TYPE')
diff --git a/Tools/c-analyzer/c_parser/parser/_alt.py b/Tools/c-analyzer/c_parser/parser/_alt.py
deleted file mode 100644 (file)
index 05a9101..0000000
+++ /dev/null
@@ -1,6 +0,0 @@
-
-def _parse(srclines, anon_name):
-    text = ' '.join(l for _, l in srclines)
-
-    from ._delim import parse
-    yield from parse(text, anon_name)
diff --git a/Tools/c-analyzer/c_parser/parser/_delim.py b/Tools/c-analyzer/c_parser/parser/_delim.py
deleted file mode 100644 (file)
index 51433a6..0000000
+++ /dev/null
@@ -1,54 +0,0 @@
-import re
-import textwrap
-
-from ._regexes import _ind, STRING_LITERAL
-
-
-def parse(text, anon_name):
-    context = None
-    data = None
-    for m in DELIMITER_RE.find_iter(text):
-        before, opened, closed = m.groups()
-        delim = opened or closed
-
-        handle_segment = HANDLERS[context][delim]
-        result, context, data = handle_segment(before, delim, data)
-        if result:
-            yield result
-
-
-DELIMITER = textwrap.dedent(rf'''
-    (
-        (?:
-            [^'"()\[\]{};]*
-            {_ind(STRING_LITERAL, 3)}
-        }*
-        [^'"()\[\]{};]+
-     )?  # <before>
-    (?:
-        (
-            [(\[{]
-         )  # <open>
-        |
-        (
-            [)\]};]
-         )  # <close>
-     )?
-    ''')
-DELIMITER_RE = re.compile(DELIMITER, re.VERBOSE)
-
-_HANDLERS = {
-    None: {  # global
-        # opened
-        '{': ...,
-        '[': None,
-        '(': None,
-        # closed
-        '}': None,
-        ']': None,
-        ')': None,
-        ';': ...,
-    },
-    '': {
-    },
-}
index 35947c129981350278d8791355765175921a881b..b1ac9f5db034e1f748df5018e06f1279f7320750 100644 (file)
@@ -9,7 +9,6 @@ from ._common import (
     set_capture_groups,
 )
 from ._compound_decl_body import DECL_BODY_PARSERS
-#from ._func_body import parse_function_body
 from ._func_body import parse_function_statics as parse_function_body
 
 
index fe7a16726f45a9d6e1342621d9d2edb583e82a97..ec026c6932f1f4839a4fc5947a820fcad167741d 100644 (file)
@@ -2,7 +2,6 @@ import logging
 import sys
 import textwrap
 
-from c_common.fsutil import expand_filenames, iter_files_by_suffix
 from c_common.scriptutil import (
     VERBOSITY,
     add_verbosity_cli,
@@ -11,7 +10,6 @@ from c_common.scriptutil import (
     add_kind_filtering_cli,
     add_files_cli,
     add_progress_cli,
-    main_for_filenames,
     process_args_by_key,
     configure_logger,
     get_prog,
index cfe5e75f2f4df69df6044883bb5dbf735c19de55..68d6b31cf2b6f0ed15be8eb565c4425d54eb3c59 100644 (file)
@@ -4,16 +4,12 @@ import re
 from c_common.clsutil import classonly
 from c_parser.info import (
     KIND,
-    DeclID,
     Declaration,
     TypeDeclaration,
-    TypeDef,
-    Struct,
     Member,
     FIXED_TYPE,
 )
 from c_parser.match import (
-    is_type_decl,
     is_pots,
     is_funcptr,
 )
index df8159a8cc169f14fcfa668e9516883f23688e44..4552f71479bd06ae0885a2885d9b185a4e0478f9 100644 (file)
@@ -7,7 +7,7 @@ import textwrap
 
 from c_common.tables import build_table, resolve_columns
 from c_parser.parser._regexes import _ind
-from ._files import iter_header_files, resolve_filename
+from ._files import iter_header_files
 from . import REPO_ROOT
 
 
@@ -610,8 +610,7 @@ def _render_item_full(item, groupby, verbose):
     yield item.name
     yield f'  {"filename:":10} {item.relfile}'
     for extra in ('kind', 'level'):
-        #if groupby != extra:
-            yield f'  {extra+":":10} {getattr(item, extra)}'
+        yield f'  {extra+":":10} {getattr(item, extra)}'
     if verbose:
         print('  ---------------------------------------')
         for lno, line in enumerate(item.text, item.lno):
@@ -636,7 +635,6 @@ def render_summary(items, *,
 
     subtotals = summary['totals']['subs']
     bygroup = summary['totals']['bygroup']
-    lastempty = False
     for outer, subtotal in subtotals.items():
         if bygroup:
             subtotal = f'({subtotal})'
@@ -646,10 +644,6 @@ def render_summary(items, *,
         if outer in bygroup:
             for inner, count in bygroup[outer].items():
                 yield f'   {inner + ":":9} {count}'
-            lastempty = False
-        else:
-            lastempty = True
-
     total = f'*{summary["totals"]["all"]}*'
     label = '*total*:'
     if bygroup: