]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2023 15:05:12 +0000 (15:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2023 15:05:12 +0000 (15:05 +0000)
added patches:
io_uring-fix-off-by-one-bvec-index.patch

queue-5.4/io_uring-fix-off-by-one-bvec-index.patch [new file with mode: 0644]
queue-5.4/series

diff --git a/queue-5.4/io_uring-fix-off-by-one-bvec-index.patch b/queue-5.4/io_uring-fix-off-by-one-bvec-index.patch
new file mode 100644 (file)
index 0000000..2213f01
--- /dev/null
@@ -0,0 +1,35 @@
+From aa4df1efa47241f8b9faab93f9d73eda4aa9ccf3 Mon Sep 17 00:00:00 2001
+From: Keith Busch <kbusch@kernel.org>
+Date: Mon, 20 Nov 2023 14:18:31 -0800
+Subject: io_uring: fix off-by one bvec index
+
+From: Keith Busch <kbusch@kernel.org>
+
+commit d6fef34ee4d102be448146f24caf96d7b4a05401 upstream.
+
+If the offset equals the bv_len of the first registered bvec, then the
+request does not include any of that first bvec. Skip it so that drivers
+don't have to deal with a zero length bvec, which was observed to break
+NVMe's PRP list creation.
+
+Cc: stable@vger.kernel.org
+Fixes: bd11b3a391e3 ("io_uring: don't use iov_iter_advance() for fixed buffers")
+Signed-off-by: Keith Busch <kbusch@kernel.org>
+Link: https://lore.kernel.org/r/20231120221831.2646460-1-kbusch@meta.com
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/io_uring.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/fs/io_uring.c
++++ b/fs/io_uring.c
+@@ -1256,7 +1256,7 @@ static int io_import_fixed(struct io_rin
+                */
+               const struct bio_vec *bvec = imu->bvec;
+-              if (offset <= bvec->bv_len) {
++              if (offset < bvec->bv_len) {
+                       iov_iter_advance(iter, offset);
+               } else {
+                       unsigned long seg_skip;
index 0635efcecfd2f3c7c256a874a802b20b791a4850..8081d0ea1086299962ecd5dbb49e23d2be02a689 100644 (file)
@@ -47,3 +47,4 @@ usb-dwc2-write-hcint-with-intmask-applied.patch
 usb-dwc3-set-the-dma-max_seg_size.patch
 usb-dwc3-qcom-fix-resource-leaks-on-probe-deferral.patch
 usb-dwc3-qcom-fix-wakeup-after-probe-deferral.patch
+io_uring-fix-off-by-one-bvec-index.patch