]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-45195: Fix test_readline.test_nonascii() (GH-28329) (GH-28984)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 19 Oct 2021 19:14:36 +0000 (12:14 -0700)
committerGitHub <noreply@github.com>
Tue, 19 Oct 2021 19:14:36 +0000 (21:14 +0200)
Fix test_readline.test_nonascii(): sometimes, the newline character
is not written at the end, so don't expect it in the output.
(cherry picked from commit 797c8eb9ef511f0c25f10a453b35c4d2fe383c30)

Co-authored-by: Victor Stinner <vstinner@python.org>
Lib/test/test_readline.py
Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst [new file with mode: 0644]

index 67ee9b7f7cfb1f4f65ea839058c508511349c69e..3574657cf3635da14dd2601344d683f5e5e37041 100644 (file)
@@ -232,7 +232,9 @@ print("history", ascii(readline.get_history_item(1)))
             self.assertIn(b"matches ['t\\xebnt', 't\\xebxt']\r\n", output)
         expected = br"'[\xefnserted]|t\xebxt[after]'"
         self.assertIn(b"result " + expected + b"\r\n", output)
-        self.assertIn(b"history " + expected + b"\r\n", output)
+        # bpo-45195: Sometimes, the newline character is not written at the
+        # end, so don't expect it in the output.
+        self.assertIn(b"history " + expected, output)
 
     # We have 2 reasons to skip this test:
     # - readline: history size was added in 6.0
diff --git a/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst b/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst
new file mode 100644 (file)
index 0000000..16a1f44
--- /dev/null
@@ -0,0 +1,3 @@
+Fix test_readline.test_nonascii(): sometimes, the newline character is not
+written at the end, so don't expect it in the output. Patch by Victor
+Stinner.