]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/display: log fail from intel_sdvo_enable_hotplug
authorJuha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Fri, 5 Sep 2025 10:46:25 +0000 (13:46 +0300)
committerMika Kahola <mika.kahola@intel.com>
Fri, 5 Sep 2025 12:24:45 +0000 (15:24 +0300)
Report in log if intel_sdvo_enable_hotplug failed

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Link: https://lore.kernel.org/r/20250905104626.1274147-2-juhapekka.heikkila@gmail.com
drivers/gpu/drm/i915/display/intel_sdvo.c

index 8848a33fe9cc1c45eb19fc3db1e37920e07ef1c3..6c032d81e7ee27464674f12b266ffebba78d5d32 100644 (file)
@@ -2052,8 +2052,10 @@ static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder)
 {
        struct intel_sdvo *intel_sdvo = to_sdvo(encoder);
 
-       intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
-                            &intel_sdvo->hotplug_active, 2);
+       if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG,
+                                 &intel_sdvo->hotplug_active, 2))
+               drm_warn(intel_sdvo->base.base.dev,
+                        "Failed to enable hotplug on SDVO encoder\n");
 }
 
 static enum intel_hotplug_state