]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:rpcclient: Do not pass uninitialized pointer to printf() (CID 1476170)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Fri, 6 Oct 2023 02:07:24 +0000 (15:07 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 13 Oct 2023 02:18:31 +0000 (02:18 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/rpcclient/cmd_spoolss.c

index dc8bbd161858c0d0d084e1bbd0153e58f4f28387..f425e75f1aba376edfd8e94de4f46c2e7f49dd8b 100644 (file)
@@ -2129,7 +2129,7 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
        const char *environment = SPOOLSS_ARCHITECTURE_NT_X86;
        DATA_BLOB buffer;
        uint32_t offered;
-       union spoolss_PrintProcessorDirectoryInfo info;
+       union spoolss_PrintProcessorDirectoryInfo info = {};
        uint32_t needed;
        struct dcerpc_binding_handle *b = cli->binding_handle;
 
@@ -2173,7 +2173,7 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
                }
        }
 
-       if (W_ERROR_IS_OK(result)) {
+       if (W_ERROR_IS_OK(result) && info.info1.directory_name != NULL) {
                printf("%s\n", info.info1.directory_name);
        }