net: sparx5: replace sparx5_start() with sparx5_forwarding_init()

With all subsystem initializations moved out, sparx5_start() only sets
up forwarding (UPSIDs, CPU ports, masks, PGIDs, FCS, watermarks).
Rename it to sparx5_forwarding_init() and make it void since it cannot
fail. This removes sparx5_start() entirely.

Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
Link: https://patch.msgid.link/20260227-sparx5-init-deinit-v2-9-10ba54ccf005@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
index d86a5d1f495fbc5c5c6e79fec48e3481c28a77e3..dad713e9ddd5bd8f20e595fe5491254c99af8989 100644 (file)
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
@@ -735,7 +735,7 @@ static void sparx5_board_init(struct sparx5 *sparx5)
                                        GCB_HW_SGPIO_TO_SD_MAP_CFG(idx));
 }
 
-static int sparx5_start(struct sparx5 *sparx5)
+static void sparx5_forwarding_init(struct sparx5 *sparx5)
 {
        const struct sparx5_consts *consts = sparx5->data->consts;
        u32 idx;
@@ -779,7 +779,6 @@ static int sparx5_start(struct sparx5 *sparx5)
        /* Enable queue limitation watermarks */
        sparx5_qlim_set(sparx5);
 
-       return 0;
 }
 
 static int mchp_sparx5_probe(struct platform_device *pdev)
@@ -943,12 +942,7 @@ static int mchp_sparx5_probe(struct platform_device *pdev)
        sparx5_pgid_init(sparx5);
        sparx5_vlan_init(sparx5);
        sparx5_board_init(sparx5);
-
-       err = sparx5_start(sparx5);
-       if (err) {
-               dev_err(sparx5->dev, "Start failed\n");
-               goto cleanup_ports;
-       }
+       sparx5_forwarding_init(sparx5);
 
        err = sparx5_calendar_init(sparx5);
        if (err) {