]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nsfs: use inode_just_drop()
authorChristian Brauner <brauner@kernel.org>
Wed, 29 Oct 2025 12:20:15 +0000 (13:20 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 31 Oct 2025 09:16:23 +0000 (10:16 +0100)
Currently nsfs uses the default inode_generic_drop() fallback which
drops the inode when it's unlinked or when it's unhashed. Since nsfs
never hashes inodes that always amounts to dropping the inode.

But that's just annoying to have to reason through every time we look at
this code. Switch to inode_just_drop() which always drops the inode
explicitly. This also aligns the behavior with pidfs which does the
same.

Link: https://patch.msgid.link/20251029-work-namespace-nstree-listns-v4-2-2e6f823ebdc0@kernel.org
Tested-by: syzbot@syzkaller.appspotmail.com
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/nsfs.c

index 79b026a36fb628db69700f7441cf611bb26531e3..ded833f66d4d51cc12b63a6254e78c68ee9f3d7d 100644 (file)
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -408,6 +408,7 @@ static const struct super_operations nsfs_ops = {
        .statfs = simple_statfs,
        .evict_inode = nsfs_evict,
        .show_path = nsfs_show_path,
+       .drop_inode = inode_just_drop,
 };
 
 static int nsfs_init_inode(struct inode *inode, void *data)