dnsdist: Fix a caching bug when all servers are down and the query was received over TCP

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 47c5c42ff534eba78b177c95bac55605cc5f8996..1485f11d1321dc9e4a8997336f1670e52c8a27d2 100644 (file)
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -1451,8 +1451,8 @@ ProcessQueryResult processQueryAfterRules(DNSQuestion& dnsQuestion, std::shared_
     if (selectedBackend && selectedBackend->isTCPOnly()) {
       willBeForwardedOverUDP = false;
     }
-    else if (!selectedBackend) {
-      willBeForwardedOverUDP = !serverPool.isTCPOnly();
+    else if (!selectedBackend && serverPool.isTCPOnly()) {
+      willBeForwardedOverUDP = false;
     }
 
     uint32_t allowExpired = 0;