staging: rtl8723bs: remove custom is_broadcast_mac_addr() function

Replace the custom broadcast address checking function with standard
kernel is_broadcast_ether_addr() func for this.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260323150650.7168-6-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c20a143ace4b9a0fbff1d8833bff241f6073ed1e..904ff0e14ec5aac6585214b6de29ecac6860bd11 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -12,7 +12,7 @@ u8 rtw_validate_bssid(u8 *bssid)
        u8 ret = true;
 
        if (is_zero_ether_addr(bssid) ||
-           is_broadcast_mac_addr(bssid) ||
+           is_broadcast_ether_addr(bssid) ||
            is_multicast_mac_addr(bssid))
                ret = false;
 

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c5182438fd051e8b2e60ce9814e7f8d2121f7170..09cff9499a59eedb2a25cfbb918ab4da4aad6385 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1274,7 +1274,7 @@ static signed int validate_recv_mgnt_frame(struct adapter *padapter, union recv_
                            GetAddr1Ptr(precv_frame->u.hdr.rx_data),
                            ETH_ALEN))
                        psta->sta_stats.rx_probersp_pkts++;
-               else if (is_broadcast_mac_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)) ||
+               else if (is_broadcast_ether_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)) ||
                         is_multicast_mac_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)))
                        psta->sta_stats.rx_probersp_bm_pkts++;
                else

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index 8f1f960b75352ef64503548673e5340a7f800ee7..4edcbd95aab3abe9cbc9befdb8d02436ba193d39 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -531,7 +531,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
                                        if (start == 0)
                                                start = jiffies;
 
-                                       if (is_broadcast_mac_addr(prxattrib->ra))
+                                       if (is_broadcast_ether_addr(prxattrib->ra))
                                                no_gkey_bc_cnt++;
                                        else
                                                no_gkey_mc_cnt++;
@@ -1225,7 +1225,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe)
                        if (start == 0)
                                start = jiffies;
 
-                       if (is_broadcast_mac_addr(prxattrib->ra))
+                       if (is_broadcast_ether_addr(prxattrib->ra))
                                no_gkey_bc_cnt++;
                        else
                                no_gkey_mc_cnt++;

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 37b9b363c073e891c932111ed4a24fbb4622e022..c3e06e6934959ac554f8503abdb13810df896c39 100644 (file)
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -512,12 +512,6 @@ static inline int is_multicast_mac_addr(const u8 *addr)
        return ((addr[0] != 0xff) && (0x01 & addr[0]));
 }
 
-static inline int is_broadcast_mac_addr(const u8 *addr)
-{
-       return ((addr[0] == 0xff) && (addr[1] == 0xff) && (addr[2] == 0xff) &&   \
-               (addr[3] == 0xff) && (addr[4] == 0xff) && (addr[5] == 0xff));
-}
-
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)