]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: dev: keep the max bitrate error at 5%
authorHaibo Chen <haibo.chen@nxp.com>
Fri, 6 Mar 2026 09:04:48 +0000 (17:04 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 10 Mar 2026 10:12:52 +0000 (11:12 +0100)
Commit b360a13d44db ("can: dev: print bitrate error with two decimal
digits") changed calculation of the bit rate error from on-tenth of a
percent to on-hundredth of a percent, but forgot to adjust the scale of the
CAN_CALC_MAX_ERROR constant.

Keeping the existing logic unchanged: Only when the bitrate error exceeds
5% should an error be returned. Otherwise, simply output a warning log.

Fixes: b360a13d44db ("can: dev: print bitrate error with two decimal digits")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Link: https://patch.msgid.link/20260306-can-fix-v1-1-ac526cec6777@nxp.com
Cc: stable@kernel.org
[mkl: improve commit message]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dev/calc_bittiming.c

index cc4022241553fa6389c2cde698456de723ef6929..42498e9d3f38dbe8b9389d250d2d53798963839f 100644 (file)
@@ -8,7 +8,7 @@
 #include <linux/units.h>
 #include <linux/can/dev.h>
 
-#define CAN_CALC_MAX_ERROR 50 /* in one-tenth of a percent */
+#define CAN_CALC_MAX_ERROR 500 /* max error 5% */
 
 /* CiA recommended sample points for Non Return to Zero encoding. */
 static int can_calc_sample_point_nrz(const struct can_bittiming *bt)