]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
powerpc/52xx/media5200: Consolidate chained IRQ handler install/remove
authorChen Ni <nichen@iscas.ac.cn>
Mon, 19 Jan 2026 06:04:50 +0000 (14:04 +0800)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Wed, 1 Apr 2026 03:51:05 +0000 (09:21 +0530)
The driver currently sets the handler data and the chained handler in
two separate steps. This creates a theoretical race window where an
interrupt could fire after the handler is set but before the data is
assigned, leading to a NULL pointer dereference.

Replace the two calls with irq_set_chained_handler_and_data() to set
both the handler and its data atomically under the irq_desc->lock.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20260119060450.889119-1-nichen@iscas.ac.cn
arch/powerpc/platforms/52xx/media5200.c

index bc7f83cfec1dc779d5dfd844c72a1b5eeb42e5a0..c20ac8010f6d19b8e4be84372fdd86df5d0289af 100644 (file)
@@ -176,8 +176,8 @@ static void __init media5200_init_irq(void)
 
        of_node_put(fpga_np);
 
-       irq_set_handler_data(cascade_virq, &media5200_irq);
-       irq_set_chained_handler(cascade_virq, media5200_irq_cascade);
+       irq_set_chained_handler_and_data(cascade_virq, media5200_irq_cascade,
+                                        &media5200_irq);
 
        return;