]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Don’t let invalid line in setup.cfg pass silently
authorÉric Araujo <merwok@netwok.org>
Sat, 10 Sep 2011 16:22:04 +0000 (18:22 +0200)
committerÉric Araujo <merwok@netwok.org>
Sat, 10 Sep 2011 16:22:04 +0000 (18:22 +0200)
Lib/packaging/config.py

index e02800e96052b9bced731aa66705e0e9822376da..366faea4ede9a99e8e7d9d7700313c873cca3dba 100644 (file)
@@ -227,10 +227,11 @@ class Config:
                 self.dist.scripts = [self.dist.scripts]
 
             self.dist.package_data = {}
-            for data in files.get('package_data', []):
-                data = data.split('=')
+            for line in files.get('package_data', []):
+                data = line.split('=')
                 if len(data) != 2:
-                    continue  # FIXME errors should never pass silently
+                    raise ValueError('invalid line for package_data: %s '
+                                     '(misses "=")' % line)
                 key, value = data
                 self.dist.package_data[key.strip()] = value.strip()