]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
catch another overlong malloc possibility. found by cypherpunks
authorNick Mathewson <nickm@torproject.org>
Sat, 15 Jan 2011 15:42:11 +0000 (10:42 -0500)
committerNick Mathewson <nickm@torproject.org>
Sat, 15 Jan 2011 15:42:11 +0000 (10:42 -0500)
src/or/routerparse.c

index 070c61b1a1bd2629f8a2f7b5ba97aedbe0f866e8..3aaefec681ddb052e1e1e37c2809c6aace029d65 100644 (file)
@@ -3105,7 +3105,8 @@ get_next_token(memarea_t *area,
 
   obstart = *s; /* Set obstart to start of object spec */
   if (*s+16 >= eol || memchr(*s+11,'\0',eol-*s-16) || /* no short lines, */
-      strcmp_len(eol-5, "-----", 5)) {          /* nuls or invalid endings */
+      strcmp_len(eol-5, "-----", 5) ||           /* nuls or invalid endings */
+      (eol-*s) > MAX_UNPARSED_OBJECT_SIZE) {     /* name too long */
     RET_ERR("Malformed object: bad begin line");
   }
   tok->object_type = STRNDUP(*s+11, eol-*s-16);