]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regmap: Fix regmap_bulk_read in BE mode
authorArun Chandran <achandran@mvista.com>
Mon, 15 Jun 2015 10:29:02 +0000 (15:59 +0530)
committerLuis Henriques <luis.henriques@canonical.com>
Wed, 15 Jul 2015 09:00:35 +0000 (10:00 +0100)
commit 15b8d2c41fe5839582029f65c5f7004db451cc2b upstream.

In big endian mode regmap_bulk_read gives incorrect data
for byte reads.

This is because memcpy of a single byte from an address
after full word read gives different results when
endianness differs. ie. we get little-end in LE and big-end in BE.

Signed-off-by: Arun Chandran <achandran@mvista.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/base/regmap/regmap.c

index 457d335f8495c23936da27242cd96605a07fc1ff..09fe07b6e98be40841c98bb80fb1679592616a94 100644 (file)
@@ -2247,7 +2247,7 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
                                          &ival);
                        if (ret != 0)
                                return ret;
-                       memcpy(val + (i * val_bytes), &ival, val_bytes);
+                       map->format.format_val(val + (i * val_bytes), ival, 0);
                }
        }