]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
HID: apple: ensure the keyboard backlight is off if suspending
authorAditya Garg <gargaditya08@live.com>
Sat, 4 Apr 2026 09:44:34 +0000 (15:14 +0530)
committerJiri Kosina <jkosina@suse.com>
Thu, 9 Apr 2026 15:46:46 +0000 (17:46 +0200)
Some users reported that upon suspending their keyboard backlight
remained on. Fix this by adding the missing LED_CORE_SUSPENDRESUME flag.

Cc: stable@vger.kernel.org
Fixes: 394ba612f941 ("HID: apple: Add support for magic keyboard backlight on T2 Macs")
Fixes: 9018eacbe623 ("HID: apple: Add support for keyboard backlight on certain T2 Macs.")
Reported-by: André Eikmeyer <andre.eikmeyer@gmail.com>
Tested-by: André Eikmeyer <andre.eikmeyer@gmail.com>
Signed-off-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-apple.c

index 9dcb252c5d6c781a8a77c538695851a971230049..cb1bd6dca8356ab4d739c830370e15903e6df4ee 100644 (file)
@@ -858,6 +858,7 @@ static int apple_backlight_init(struct hid_device *hdev)
        asc->backlight->cdev.name = "apple::kbd_backlight";
        asc->backlight->cdev.max_brightness = rep->backlight_on_max;
        asc->backlight->cdev.brightness_set_blocking = apple_backlight_led_set;
+       asc->backlight->cdev.flags = LED_CORE_SUSPENDRESUME;
 
        ret = apple_backlight_set(hdev, 0, 0);
        if (ret < 0) {
@@ -926,6 +927,7 @@ static int apple_magic_backlight_init(struct hid_device *hdev)
        backlight->cdev.name = ":white:" LED_FUNCTION_KBD_BACKLIGHT;
        backlight->cdev.max_brightness = backlight->brightness->field[0]->logical_maximum;
        backlight->cdev.brightness_set_blocking = apple_magic_backlight_led_set;
+       backlight->cdev.flags = LED_CORE_SUSPENDRESUME;
 
        apple_magic_backlight_set(backlight, 0, 0);