]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 3173: Assertion bodyPipe!=NULL on SslBump CONNECT response writing failure
authorAlex Rousskov <rousskov@measurement-factory.com>
Thu, 24 Mar 2011 15:48:34 +0000 (09:48 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Thu, 24 Mar 2011 15:48:34 +0000 (09:48 -0600)
Do not call ConnStateData::startClosing() when we fail to write our CONNECT
response while bumping a connection. startClosing() can only be used when we
handle response bodies. Just close the connection, in hope that the connection
close handler kicks in and cleans up.

src/client_side_request.cc

index 60290aec56dcb5433ecdbbdc7e80de798d0a21a3..f5aeb5d139d04785f511555b85bf9a7fa6777b25 100644 (file)
@@ -1189,7 +1189,8 @@ ClientHttpRequest::sslBumpEstablish(comm_err_t errflag)
         return;
 
     if (errflag) {
-        getConn()->startClosing("CONNECT response failure in SslBump");
+        debugs(85, 3, HERE << "CONNECT response failure in SslBump: " << errflag);
+        comm_close(getConn()->fd);
         return;
     }