]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ovl: port ovl_llseek() to cred guard
authorChristian Brauner <brauner@kernel.org>
Mon, 17 Nov 2025 09:33:39 +0000 (10:33 +0100)
committerChristian Brauner <brauner@kernel.org>
Wed, 19 Nov 2025 20:58:20 +0000 (21:58 +0100)
Use the scoped ovl cred guard.

Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-v4-8-b31603935724@kernel.org
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/overlayfs/file.c

index ebcd737e87ef14fe3ff5d0060d82992bef6beb15..70ddb51297ce8b832b5fd1bda9b3c28518564eca 100644 (file)
@@ -243,7 +243,6 @@ static loff_t ovl_llseek(struct file *file, loff_t offset, int whence)
 {
        struct inode *inode = file_inode(file);
        struct file *realfile;
-       const struct cred *old_cred;
        loff_t ret;
 
        /*
@@ -272,9 +271,8 @@ static loff_t ovl_llseek(struct file *file, loff_t offset, int whence)
        ovl_inode_lock(inode);
        realfile->f_pos = file->f_pos;
 
-       old_cred = ovl_override_creds(inode->i_sb);
-       ret = vfs_llseek(realfile, offset, whence);
-       ovl_revert_creds(old_cred);
+       with_ovl_creds(inode->i_sb)
+               ret = vfs_llseek(realfile, offset, whence);
 
        file->f_pos = realfile->f_pos;
        ovl_inode_unlock(inode);