]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #19857: Make sure that test_imaplib reaps server threads even in face of
authorCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:03:12 +0000 (20:03 +0100)
committerCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:03:12 +0000 (20:03 +0100)
error upon client disconnection.

Lib/test/test_imaplib.py

index c37ea1dccf10403db96090423a233db464c82da0..2435be5b0f9f3c73b443902e47a824615dda417b 100644 (file)
@@ -210,13 +210,12 @@ class BaseThreadedNetworkedTests(unittest.TestCase):
 
     @contextmanager
     def reaped_pair(self, hdlr):
-        server, thread = self.make_server((support.HOST, 0), hdlr)
-        client = self.imap_class(*server.server_address)
-        try:
-            yield server, client
-        finally:
-            client.logout()
-            self.reap_server(server, thread)
+        with self.reaped_server(hdlr) as server:
+            client = self.imap_class(*server.server_address)
+            try:
+                yield server, client
+            finally:
+                client.logout()
 
     @reap_threads
     def test_connect(self):