]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
x86/bugs: Qualify RETBLEED_INTEL_MSG
authorDavid Kaplan <david.kaplan@amd.com>
Fri, 3 Oct 2025 17:19:36 +0000 (12:19 -0500)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 21 Oct 2025 10:32:28 +0000 (12:32 +0200)
When retbleed mitigation is disabled, the kernel already prints an info
message that the system is vulnerable.  Recent code restructuring also
inadvertently led to RETBLEED_INTEL_MSG being printed as an error, which is
unnecessary as retbleed mitigation was already explicitly disabled (by config
option, cmdline, etc.).

Qualify this print statement so the warning is not printed unless an actual
retbleed mitigation was selected and is being disabled due to incompatibility
with spectre_v2.

Fixes: e3b78a7ad5ea ("x86/bugs: Restructure retbleed mitigation")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220624
Signed-off-by: David Kaplan <david.kaplan@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20251003171936.155391-1-david.kaplan@amd.com
arch/x86/kernel/cpu/bugs.c

index 6a526ae1fe9933229947db5b7676a18328fe2204..e08de5b0d20ba8fc2f165a4f319004631d48634e 100644 (file)
@@ -1463,7 +1463,9 @@ static void __init retbleed_update_mitigation(void)
                        break;
                default:
                        if (retbleed_mitigation != RETBLEED_MITIGATION_STUFF) {
-                               pr_err(RETBLEED_INTEL_MSG);
+                               if (retbleed_mitigation != RETBLEED_MITIGATION_NONE)
+                                       pr_err(RETBLEED_INTEL_MSG);
+
                                retbleed_mitigation = RETBLEED_MITIGATION_NONE;
                        }
                }