core/unit: check the validity of unit type with activation_details_vtable

Follow-up for 24e91e08f8958241195f97472353adef94884b33.

diff --git a/src/core/unit.c b/src/core/unit.c
index 4e9ae6148f396b08c4f137475cdfdd8b34d4e524..d275adb9b0f51aa163ea3acdb9f9c537e03b385a 100644 (file)
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -6162,9 +6162,11 @@ int activation_details_deserialize(const char *key, const char *value, Activatio
                         return -EINVAL;
 
                 t = unit_type_from_string(value);
-                /* The activation details vtable has defined ops only for path
-                 * and timer units */
-                if (!IN_SET(t, UNIT_PATH, UNIT_TIMER))
+                if (t < 0)
+                        return t;
+
+                /* The activation details vtable has defined ops only for path and timer units */
+                if (!activation_details_vtable[t])
                         return -EINVAL;
 
                 *details = malloc0(activation_details_vtable[t]->object_size);