]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
feat(compiler-dom): v-cloak transform (#141)
authorAdam Dorling <adam.x.dorling@gmail.com>
Wed, 9 Oct 2019 14:41:31 +0000 (15:41 +0100)
committerEvan You <yyx990803@gmail.com>
Wed, 9 Oct 2019 14:41:31 +0000 (10:41 -0400)
packages/compiler-dom/__tests__/transforms/vCloak.spec.ts [new file with mode: 0644]
packages/compiler-dom/src/index.ts
packages/compiler-dom/src/transforms/vCloak.ts

diff --git a/packages/compiler-dom/__tests__/transforms/vCloak.spec.ts b/packages/compiler-dom/__tests__/transforms/vCloak.spec.ts
new file mode 100644 (file)
index 0000000..a9c84a4
--- /dev/null
@@ -0,0 +1,32 @@
+import {
+  parse,
+  transform,
+  CompilerOptions,
+  ElementNode
+} from '@vue/compiler-core'
+import { transformCloak } from '../../src/transforms/vCloak'
+import { transformElement } from '../../../compiler-core/src/transforms/transformElement'
+import { CallExpression } from '../../src'
+
+function transformWithCloak(template: string, options: CompilerOptions = {}) {
+  const ast = parse(template)
+  transform(ast, {
+    nodeTransforms: [transformElement],
+    directiveTransforms: {
+      cloak: transformCloak
+    },
+    ...options
+  })
+  return ast.children[0] as ElementNode
+}
+
+describe('compiler: `v-cloak` transform', () => {
+  test('should add no props to DOM', () => {
+    const node = transformWithCloak(`<div v-cloak/>`)
+    const codegenArgs = (node.codegenNode as CallExpression).arguments
+
+    // As v-cloak adds no properties the codegen should be identical to
+    // rendering a div with no props or reactive data (so just the tag as the arg)
+    expect(codegenArgs.length).toBe(1)
+  })
+})
index fa7855fd50c2ccc9036bcd0ffaf90dcfcbfca957..7d61080e808f751ab16c8e9f9817b0d82d7b8bb7 100644 (file)
@@ -2,6 +2,7 @@ import { baseCompile, CompilerOptions, CodegenResult } from '@vue/compiler-core'
 import { parserOptionsMinimal } from './parserOptionsMinimal'
 import { parserOptionsStandard } from './parserOptionsStandard'
 import { transformStyle } from './transforms/transformStyle'
+import { transformCloak } from './transforms/vCloak'
 import { transformVHtml } from './transforms/vHtml'
 
 export function compile(
@@ -13,6 +14,7 @@ export function compile(
     ...(__BROWSER__ ? parserOptionsMinimal : parserOptionsStandard),
     nodeTransforms: [transformStyle, ...(options.nodeTransforms || [])],
     directiveTransforms: {
+      cloak: transformCloak,
       html: transformVHtml,
       ...(options.directiveTransforms || {})
     }
index 70b786d12ed055a08b57f5cf47f717bf6a266301..b5f8666278533e809cfb900d3f4ee22112e9ebca 100644 (file)
@@ -1 +1,5 @@
-// TODO
+import { DirectiveTransform } from 'packages/compiler-core/src/transform'
+
+export const transformCloak: DirectiveTransform = (node, context) => {
+  return { props: [], needRuntime: false }
+}