netcmd: models: fix build_expression on SIDField handles security.dom_sid

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/netcmd/domain/models/fields.py b/python/samba/netcmd/domain/models/fields.py
index c02562e7c3704a9f1b51d693ebac2195c32cf0dd..ab91eb84275f4586240bd11da48024367359f2cf 100644 (file)
--- a/python/samba/netcmd/domain/models/fields.py
+++ b/python/samba/netcmd/domain/models/fields.py
@@ -347,6 +347,11 @@ class SIDField(Field):
             return MessageElement(ndr_pack(security.dom_sid(value)),
                                   flags, self.name)
 
+    def expression(self, value):
+        """Returns the ldb search expression for this field."""
+        # NOTE: value can be str or `security.dom_sid` so convert to str first.
+        return f"({self.name}={binary_encode(str(value))})"
+
 
 class SDDLField(Field):
     """A SDDL field encodes and decodes SDDL data."""