]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/vboxvideo: Switch to drm_atomic_get_new_crtc_state()
authorMaxime Ripard <mripard@kernel.org>
Tue, 30 Sep 2025 10:59:46 +0000 (12:59 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 6 Oct 2025 11:59:19 +0000 (13:59 +0200)
The vboxvideo atomic_check implementation uses the deprecated
drm_atomic_get_existing_crtc_state() helper.

This hook is called as part of the global atomic_check, thus before the
states are swapped. The existing state thus points to the new state, and
we can use drm_atomic_get_new_crtc_state() instead.

Reviewed-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250930-drm-no-more-existing-state-v5-31-eeb9e1287907@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/vboxvideo/vbox_mode.c

index 9ff3bade979577df0bc2e6e9653b3fb8fd486062..aa0dded595b6e00a9aa2027b36ca11711ccc0439 100644 (file)
@@ -262,8 +262,8 @@ static int vbox_primary_atomic_check(struct drm_plane *plane,
        struct drm_crtc_state *crtc_state = NULL;
 
        if (new_state->crtc) {
-               crtc_state = drm_atomic_get_existing_crtc_state(state,
-                                                               new_state->crtc);
+               crtc_state = drm_atomic_get_new_crtc_state(state,
+                                                          new_state->crtc);
                if (WARN_ON(!crtc_state))
                        return -EINVAL;
        }
@@ -344,8 +344,8 @@ static int vbox_cursor_atomic_check(struct drm_plane *plane,
        int ret;
 
        if (new_state->crtc) {
-               crtc_state = drm_atomic_get_existing_crtc_state(state,
-                                                               new_state->crtc);
+               crtc_state = drm_atomic_get_new_crtc_state(state,
+                                                          new_state->crtc);
                if (WARN_ON(!crtc_state))
                        return -EINVAL;
        }